Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> writes: > On Wed, Jan 11, 2023 at 07:00:33PM +0200, Kalle Valo wrote: >> From: P Praneesh <quic_ppranees@xxxxxxxxxxx> >> >> On platforms with two or more QCN9074 devices, the QMI service will run with >> identical QRTR ids. qmi_add_lookup() is called with same qmi.service_ins_id. > > identical QRTR instance ID. Will fix. >> Kalle's comments: >> >> Depends on: https://patchwork.kernel.org/project/linux-wireless/list/?series=710862&order=date >> >> It's also possible to do a simple test by just changing the test >> "test_bit(ATH11K_FW_FEATURE_MULTI_QRTR_ID, ab->fw.fw_features)" to true, no >> extra patches should be needed. >> >> I don't have a test setup for this so compile tested only. But I assume Praneesh has tested this. >> >> This is alternative approach to Robert's patchset: >> >> https://patchwork.kernel.org/project/linux-wireless/list/?series=692423&state=*&order=date >> > > For what devices the compatible firmware is available? Currently only recent QCN9074 firmware releases support this, but I don't from which release onwards. > Any plan to fix the devices with old firmware? In my opinion all ath11k PCI firmwares should support this, but AFAIK they do not. I'll push the firmware teams to implement this but it's another story if I succeed :) >> +static void ath11k_pci_update_qrtr_node_id(struct ath11k_base *ab) > > The function name says update node_id but instance_id is what getting > updated. Will fix. Thanks for the review! -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
