> -----Original Message-----
> From: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>
> Sent: Tuesday, January 10, 2023 11:43 PM
> To: linux-wireless@xxxxxxxxxxxxxxx
> Cc: Jes Sorensen <Jes.Sorensen@xxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Subject: [PATCH 2/2] wifi: rtl8xxxu: Dump the efuse only for untested devices
>From the content of this patch, I don't know why "only for untested devices",
so I dig the code and find rtl8xxxu_debug could be changed at usb_probe().
Not sure if it is worth to write into commit message, but I think this information
is helpful for other reviewers.
>
> It appears this was the intention all along, but commit 3307d84024d2
> ("rtl8xxxu: Add initial code to parse rtl8192eu efuse") initialised
> rtl8xxxu_debug with RTL8XXXU_DEBUG_EFUSE for no apparent reason, which
> made it dump the efuse for all devices, even the tested ones.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>
Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index d521435e1c07..07c3af5d0374 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -34,7 +34,7 @@
>
> #define DRIVER_NAME "rtl8xxxu"
>
> -int rtl8xxxu_debug = RTL8XXXU_DEBUG_EFUSE;
> +int rtl8xxxu_debug;
> static bool rtl8xxxu_ht40_2g;
> static bool rtl8xxxu_dma_aggregation;
> static int rtl8xxxu_dma_agg_timeout = -1;
> --
> 2.38.0
>
> ------Please consider the environment before printing this e-mail.
