On Wed, Oct 29, 2008 at 7:14 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> This fixes the basic rate bitmap calculation in mac80211.
>
> Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxx [2.6.25, 2.6.26, 2.6.27]
> ---
> Is this appropriate for stable? It's a trivial and obvious fix, and can
> throw off the duration calculation, but it's likely nobody will ever
> really notice...
You would should fail association if one of the basic rates is not
supported by the station
Tomas
>
> net/mac80211/mlme.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> --- everything.orig/net/mac80211/mlme.c 2008-10-29 18:08:12.000000000 +0100
> +++ everything/net/mac80211/mlme.c 2008-10-29 18:08:19.000000000 +0100
> @@ -1307,8 +1307,9 @@ static void ieee80211_rx_mgmt_assoc_resp
> have_higher_than_11mbit = true;
>
> for (j = 0; j < sband->n_bitrates; j++) {
> - if (sband->bitrates[j].bitrate == rate)
> - rates |= BIT(j);
> + if (sband->bitrates[j].bitrate != rate)
> + continue;
> + rates |= BIT(j);
> if (elems.supp_rates[i] & 0x80)
> basic_rates |= BIT(j);
> }
> @@ -1321,8 +1322,9 @@ static void ieee80211_rx_mgmt_assoc_resp
> have_higher_than_11mbit = true;
>
> for (j = 0; j < sband->n_bitrates; j++) {
> - if (sband->bitrates[j].bitrate == rate)
> - rates |= BIT(j);
> + if (sband->bitrates[j].bitrate != rate)
> + continue;
> + rates |= BIT(j);
> if (elems.ext_supp_rates[i] & 0x80)
> basic_rates |= BIT(j);
> }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
