On Mon, Jan 9, 2023 at 11:55 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > > Jaewan Kim <jaewan@xxxxxxxxxx> writes: > > > Preambles and bandwidths values are considered as bit shifts > > when they're are used for capabilities. > > > > Signed-off-by: Jaewan Kim <jaewan@xxxxxxxxxx> > > Reviewed-by: Kalle Valo <kvalo@xxxxxxxxxx> > > I didn't provide you a Reviewed-by tag[1] during my review, please don't > create such tags yourself. For example, in this case I didn't review the > patch in detail so I'm not comfortable giving you my Reviewed-by tag. > > The general idea is that you only copy paste the tag when someone gives > you one, you don't create them on your own. I think Reported-by is only > exception but there might be others. > > [1] https://lore.kernel.org/linux-wireless/87ili3kfdr.fsf@xxxxxxxxxx/ > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches Sorry about the newbie mistake. Let me remove the line as you advised. -- Jaewan Kim (김재완) | Software Engineer in Google Korea | jaewan@xxxxxxxxxx | +82-10-2781-5078