On 1/9/2023 10:50 AM, Arend van Spriel wrote:
A sanity check was introduced by [1] considering maximum flowrings above 256 as insane and effectively aborting the device probe. This resulted in regression for number of users and it is also tracked in bugzilla [2]. [1] https://lore.kernel.org/all/20220929031001.9962-3-ian.lin@xxxxxxxxxxxx/ [2] https://bugzilla.kernel.org/show_bug.cgi?id=216894 Fixes: 2aca4f3734bd ("brcmfmac: return error when getting invalid max_flowrings from dongle") Reported-by: chainofflowers <chainofflowers@xxxxxxxxxx> Signed-off-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c index ae57a9a3ab05..b67f6d0810b6 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c @@ -1228,7 +1228,7 @@ static int brcmf_pcie_init_ringbuffers(struct brcmf_pciedev_info *devinfo) BRCMF_NROF_H2D_COMMON_MSGRINGS; max_completionrings = BRCMF_NROF_D2H_COMMON_MSGRINGS; } - if (max_flowrings > 256) { + if (max_flowrings > 512) {
This check was added to detect firmware init failure. There should be a better way than using this parameter. For now I decided to simply double the limit to get the regression fixed.
brcmf_err(bus, "invalid max_flowrings(%d)\n", max_flowrings); return -EIO; }
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
