On 1/8/2023 9:53 PM, chainofflowers wrote:
Hi! This patch: https://lore.kernel.org/all/20220929031001.9962-3-ian.lin@xxxxxxxxxxxx/ causes my Asus PCE-AC88 (1043:86fb) to stop working, because when modprobe loads brcmfmac it throws this error: --- [ 2740.647600] brcmfmac 0000:0d:00.0: brcmf_pcie_init_ringbuffers: invalid max_flowrings(264). --- This is also being reported on reddit: https://www.reddit.com/r/archlinux/comments/104pqv9/ no_wifi_since_kernel_update_yesterday/ (also, see https://forum.manjaro.org/t/brcmfmac-fails-to-load/131128) I think that the check on value > 256 is used as a kind of red herring to indirectly spot an inconsistent properties report from the PCI bus (?) about the network card.
The firmware loaded into the wifi device requests the host for 264 flowrings. This was apparently not expected to be a valid value, but your device shows it is.
Before that patch, the driver was correctly working for me and I could not observe any kernel panic. Maybe, at least in my case, the wrong value was still reported but could be safely ignored, as at a later point in time, when the card is initialised, everything worked fine. I am now stuck at kernel 6.1.1, if I upgrade I cannot use the card. Is there anything I can do to circumvent this issue? May I help somehow with debugging & testing? Please let me know...
6.2 is not formally released so I suppose you are an early adopter and aware of the risk that implies ;-) There is no real debugging needed. I will figure out what a sensible value would be and come up with a patch. If you can test that that would be great. Will let you know.
Regards, Arend
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
