On Wed, 2008-10-29 at 19:49 +0200, Jouni Malinen wrote:
> + * enum nl80211_txq_attr - TX queue parameter attributes
> + * @NL80211_TXQ_ATTR_QUEUE: TX queue identifier (NL80211_TXQ_Q_*)
> + * @NL80211_TXQ_ATTR_TXOP: Maximum burst time in units of 32 usecs, 0 meaning
> + * disabled
> + * @NL80211_TXQ_ATTR_CWMIN: Minimum contention window [a value of the form
> + * 2^n-1 in the range 1..32767]
> + * @NL80211_TXQ_ATTR_CWMAX: Maximum contention window [a value of the form
> + * 2^n-1 in the range 1..32767]
> + * @NL80211_TXQ_ATTR_AIFS: Arbitration interframe space [0..255]
You have to add the invalid, after_last and max to the kernel-doc too
otherwise it'll warn about it.
>
> +struct ieee80211_txq_params {
> + u8 queue;
> + u16 txop;
> + u16 cwmin;
> + u16 cwmax;
> + u8 aifs;
> +};
Maybe add some kernel-doc describing the units etc.? And describing
which values are valid for 'queue' (or should that use the enum
VO/VI/...?)
> + if (info->attrs[NL80211_ATTR_WIPHY_TXQ_PARAMS]) {
> + struct ieee80211_txq_params txq_params;
> + struct nlattr *tb[NL80211_TXQ_ATTR_MAX + 1];
> +
> + nla_for_each_nested(nl_txq_params,
> + info->attrs[NL80211_ATTR_WIPHY_TXQ_PARAMS],
> + rem_txq_params) {
> + nla_parse(tb, NL80211_TXQ_ATTR_MAX,
> + nla_data(nl_txq_params),
> + nla_len(nl_txq_params),
> + txq_params_policy);
> + result = parse_txq_params(tb, &txq_params);
> + if (result)
> + goto bad_res;
> +
> + if (!rdev->ops->set_txq_params) {
> + result = -EOPNOTSUPP;
> + goto bad_res;
> + }
Seems you could do that check outside the loop?
Otherwise looks good to me, thanks.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
