> -----Original Message----- > From: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > Sent: Wednesday, January 4, 2023 11:44 PM > To: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx; kvalo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; tony0620emma@xxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/4] rtw88: Configure the registers from rtw_bf_assoc() outside the RCU lock > > Hi Ping-Ke, > > On Fri, Dec 30, 2022 at 12:48 AM Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > [...] > > > Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > > > > I think my reviewed-by should behind your signed-off-by. > My understanding is that I have to put your Reviewed-by above my > Signed-off-by since I added the Reviewed-by to the description. > If the maintainer adds your Reviewed-by while applying the patch to > the tree they will put your Reviewed-by between my Signed-off-by and > the maintainer's Signed-off-by. > > If this is incorrect then please let me know and I'll change it for v3. > My original thought is to add my reviewed-by in the order like maintainer applies the patch, but your understanding looks reasonable. Sorry for the noise. Ping-Ke
