On Do, 2022-12-22 at 11:20 +0100, Krzysztof Kozlowski wrote: > On 21/12/2022 11:48, Philipp Zabel wrote: > > Add a device tree binding document for GPIO controlled rfkill switches. > > The name, type, shutdown-gpios and reset-gpios properties are the same > > as defined for ACPI. > > > > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > You missed several maintainers. Resend. Thank you for the review, I've sent a v2: https://lore.kernel.org/all/20230102-rfkill-gpio-dt-v2-0-d1b83758c16d@xxxxxxxxxxxxxx/T [...] > > > > + shutdown-gpios: > > + maxItems: 1 > > + > > + reset-gpios: > > + maxItems: 1 > > Reset of rfkill? It seems entire binding is a workaround of missing > reset in your device. I don't think this is suitable for binding. I've dropped the reset-gpios property. The device I would like to control with this is the 'wireless disable' pin of an M.2 connector. regards Philipp
