On Mon, 2023-01-02 at 10:40 +0800, Aiden Leong wrote:
> Revert:
> commit 3f7320428fa4 ("iwlwifi: pcie: simplify iwl_pci_find_dev_info()")
>
> A bug was introduced by:
> commit 32ed101aa140 ("iwlwifi: convert all Qu with Jf devices to the new
> config table"),
> where a goto statement was removed.
Not sure I undestand what problem reversing the "for" loop solves.
>
> Signed-off-by: Aiden Leong <aiden.leong@xxxxxxxxx>
> ---
> Notice:
> Please run further tests before merging. I'm NOT familiar with device
> drivers.
> ---
> drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> index a46df1320372..5d74adbd49cf 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> @@ -1461,7 +1461,7 @@ iwl_pci_find_dev_info(u16 device, u16 subsystem_device,
> if (!num_devices)
> return NULL;
>
> - for (i = num_devices - 1; i >= 0; i--) {
> + for (i = 0; i < num_devices; i++) {
> const struct iwl_dev_info *dev_info = &iwl_dev_info_table[i];
>
> if (dev_info->device != (u16)IWL_CFG_ANY &&
