On 12/1/22 14:37, Johannes Berg wrote:
The examples don't seem to match the docs:
Indeed.. I'll fix it.
and maybe you should switch pairwise/mac addr since it's not required for pairwise == false I guess? or maybe let you specify the key type instead, so you can retrieve other kinds of keys?
I was actually thinking about removing the pairwise flag entirely. Since the kernel currently only allows to retrieve pairwise or group keys (AFAICT), I was thinking it could be easier to use the presence of the MAC address to differentiate between the key types.
and this seems like it could have some error return in the else or something?
Indeed, I'll add it.
Otherwise seems fine to me, any particular reason you sent it as RFC?
I thought there might have been a specific reason why it was not there yet, and I also wasn't sure about 'NL80211_KEY_*' vs 'NL80211_ATTR_KEY_*'. I'll send a v2 addressing the comments above. Thanks for the review! Raphaël
