Search Linux Wireless

Re: [PATCH] wifi: mac80211: Allow NSS change only up to capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2022-12-27 at 08:04 +0000, Rameshkumar Sundaram (QUIC) wrote:
> > 
> > > +		if (nss <= link_sta->pub->rx_nss) {
> > > +			link_sta->pub->rx_nss = nss;
> > 
> > That, however, doesn't seem right. It means that you can only ever
> > reduce
> > the RX NSS, not switch it around within the originally negotiated
> > range.
> > 
> Not sure if I understood you comment.
> We reset Sta's rx_nss

I don't see where it's being reset?

The way I'm reading this, you check nss<=rx_nss and then set rx_nss=nss.
I didn't see any code that sets rx_nss higher, but maybe I missed it?

So if say rx_nss is 4, and nss is 2, then we set rx_nss to 2. But now if
the AP wants to switch back to 4, nss will be 4, rx_nss will be 2, and
the change is ignored, no?

johannes




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux