Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote: > It is not allowed to call kfree_skb() or consume_skb() from hardware > interrupt context or with hardware interrupts being disabled. > > It should use dev_kfree_skb_irq() or dev_consume_skb_irq() instead. > The difference between them is free reason, dev_kfree_skb_irq() means > the SKB is dropped in error and dev_consume_skb_irq() means the SKB > is consumed in normal. > > In this case, dev_kfree_skb() is called to free and drop the SKB when > it's shutdown, so replace it with dev_kfree_skb_irq(). Compile tested > only. > > Fixes: 26f1fad29ad9 ("New driver: rtl8xxxu (mac80211)") > Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx> > Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> Patch applied to wireless-next.git, thanks. 4c2005ac8768 wifi: rtl8xxxu: don't call dev_kfree_skb() under spin_lock_irqsave() -- https://patchwork.kernel.org/project/linux-wireless/patch/20221208143517.2383424-1-yangyingliang@xxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches