Kalle Valo <kvalo@xxxxxxxxxx> wrote: > From: Kalle Valo <quic_kvalo@xxxxxxxxxxx> > > Nathan noticed that when HWSPINLOCK is disabled there's a Kconfig warning: > > WARNING: unmet direct dependencies detected for QCOM_SMEM > Depends on [n]: (ARCH_QCOM [=y] || COMPILE_TEST [=n]) && HWSPINLOCK [=n] > Selected by [m]: > - ATH10K_SNOC [=m] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && ATH10K [=m] && (ARCH_QCOM [=y] || COMPILE_TEST [=n]) > > The problem here is that QCOM_SMEM depends on HWSPINLOCK so we cannot select > QCOM_SMEM and instead we neeed to use 'depends on'. > > Reported-by: Nathan Chancellor <nathan@xxxxxxxxxx> > Link: https://lore.kernel.org/all/Y4YsyaIW+CPdHWv3@dev-arch.thelio-3990X/ > Fixes: 4d79f6f34bbb ("wifi: ath10k: Store WLAN firmware version in SMEM image table") > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> Patch applied to wireless-next.git, thanks. d03407183d97 wifi: ath10k: fix QCOM_SMEM dependency -- https://patchwork.kernel.org/project/linux-wireless/patch/20221202103027.25974-1-kvalo@xxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches