On Wed, Oct 29, 2008 at 7:08 AM, Nick Kossifidis <mickflemm@xxxxxxxxx> wrote:
> 2008/10/29 Bob Copeland <me@xxxxxxxxxxxxxxx>:
>> On Wed, Oct 29, 2008 at 04:11:22AM +0200, Nick Kossifidis wrote:
>>> * Properly clean MIC key from keytable when TKIP is used (Bob is
>>> working on set_key function etc so i leave it for now).
>>
>> Heh, I was just prepping patches to send out. I had basically the
>> same thing for _reset_key too so I'll just rebase mine on top of this.
>>
>
> ACK, sorry for the bad coordination ;-(
No worries, it was easy enough to drop that hunk. But I do think this:
> + /* Reset associated MIC entry if TKIP
> + * is enabled located at offset (entry + 64) */
> + if (type == AR5K_KEYTABLE_TYPE_TKIP) {
> + entry = entry + AR5K_KEYTABLE_MIC_OFFSET;
> + AR5K_ASSERT_ENTRY(entry, AR5K_KEYTABLE_SIZE);
> + for (i = 0; i < AR5K_KEYCACHE_SIZE / 2 ; i++)
> + ath5k_hw_reg_write(ah, 0, AR5K_KEYTABLE_OFF(entry, i));
> + }
> +
...should move a couple of lines down or use a temporary for the micentry
slot; otherwise we are setting keytype to NULL in the mic entry and not
the original key slot.
The only other difference in mine was I went ahead and reset the whole line
instead of just the first 4 words... since nothing goes in that half of the
cache line that's probably wasted effort, and the HAL does the above so it
should be fine. I just wasn't sure if power-up state clears the keytype
properly.
--
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
