On Wed, Oct 29, 2008 at 12:54:51PM +0100, Johannes Berg wrote: > On Tue, 2008-10-28 at 22:07 -0700, David Miller wrote: > > From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > > Date: Tue, 28 Oct 2008 14:00:54 +0100 > > > > > Remove converting the MAC address to a string by a direct byte > > > conversion and use %pM instead, since the code is now boilerplate > > > use a macro to define the show functions, and also use the shorter > > > __ATTR_RO macro to define the attributes. > > > > > > Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > > > --- > > > John, just FYI, it needs to go through net-next-2.6 since it depends on > > > %pM. Won't cause conflicts either :) > > > > I'll let John get this one. > > Hmm. That means it won't get into 2.6.29 because John doesn't branch > from your next tree but rather from Linus's tree, and thus we can't use > %pM yet. I can resend then, doesn't matter much. Not quite true -- wireless-testing doesn't branch from net-next-2.6, but wireless-next-2.6 does. Often that is a benefit for "just wireless" development, but sometimes not... I can push this through wireless-next-2.6 only (i.e. not in wireless-testing), Dave could take it directly, or it could just wait. Any preferences? John -- John W. Linville Linux should be at the core linville@xxxxxxxxxxxxx of your literate lifestyle. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html