Re: [PATCH] wifi: brcmfmac: Fix error return code in brcmf_sdio_download_firmware()

wangyufen <wangyufen@xxxxxxxxxx> · Wed, 30 Nov 2022 10:00:37 +0800

在 2022/11/30 1:41, Franky Lin 写道:
On Tue, Nov 29, 2022 at 1:47 AM Wang Yufen <wangyufen@xxxxxxxxxx> wrote:

Fix to return a negative error code -EINVAL instead of 0.

Compile tested only.

Fixes: d380ebc9b6fb ("brcmfmac: rename chip download functions")
Signed-off-by: Wang Yufen <wangyufen@xxxxxxxxxx>
---
  drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index 465d95d..329ec8ac 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -3414,6 +3414,7 @@ static int brcmf_sdio_download_firmware(struct brcmf_sdio *bus,
         /* Take arm out of reset */
         if (!brcmf_chip_set_active(bus->ci, rstvec)) {
                 brcmf_err("error getting out of ARM core reset\n");
+               bcmerror = -EINVAL;

ENODEV seems more appropriate here.

However, if brcmf_chip_set_active()  fails in 
brcmf_pcie_exit_download_state(), "-EINVAL" is returned.
Is it necessary to keep consistent?


                 goto err;
         }

--
1.8.3.1







