> -----Original Message----- > From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Sent: Tuesday, November 22, 2022 10:52 PM > To: linux-wireless@xxxxxxxxxxxxxxx > Cc: Neo Jou <neojou@xxxxxxxxx>; Hans Ulli Kroll <linux@xxxxxxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx>; > Yan-Hsuan Chuang <tony0620emma@xxxxxxxxx>; Kalle Valo <kvalo@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>; > kernel@xxxxxxxxxxxxxx; Johannes Berg <johannes@xxxxxxxxxxxxxxxx>; Alexander Hochbaum <alex@xxxxxxxxxx>; > Da Xue <da@libre.computer>; Bernie Huang <phhuang@xxxxxxxxxxx>; Viktor Petrenko <g0000ga@xxxxxxxxx>; > Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Subject: [PATCH v3 03/11] rtw88: Drop rf_lock > > The rtwdev->rf_lock spinlock protects the rf register accesses in > rtw_read_rf() and rtw_write_rf(). Most callers of these functions hold > rtwdev->mutex already with the exception of the callsites in the debugfs > code. The debugfs code doesn't justify an extra lock, so acquire the mutex > there as well before calling rf register accessors and drop the now > unnecessary spinlock. > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> [...]
