Ryder Lee <Ryder.Lee@xxxxxxxxxxxx> writes: > On Mon, 2022-11-21 at 17:07 +0200, Kalle Valo wrote: >> Shayne Chen <shayne.chen@xxxxxxxxxxxx> writes: >> >> > Add MediaTek new mac80211 driver mt7996 for Wi-Fi 7 (802.11be) >> > devices. >> > The driver first supports Filogic 680 PCI device, which is a Wi-Fi >> > 7 >> > chipset supporting concurrent tri-band operation at 6 GHz, 5 GHz, >> > and >> > 2.4 GHz with 4x4 antennas on each band. >> > >> > Currently, mt7996 only supports tri-band HE or older mode. >> > EHT mode and more variants of Filogic 680 support will be >> > introduced >> > in further patches. >> > >> > Reviewed-by: Ryder Lee <ryder.lee@xxxxxxxxxxxx> >> > Co-developed-by: Peter Chiu <chui-hao.chiu@xxxxxxxxxxxx> >> > Signed-off-by: Peter Chiu <chui-hao.chiu@xxxxxxxxxxxx> >> > Co-developed-by: Bo Jiao <Bo.Jiao@xxxxxxxxxxxx> >> > Signed-off-by: Bo Jiao <Bo.Jiao@xxxxxxxxxxxx> >> > Co-developed-by: Howard Hsu <howard-yh.hsu@xxxxxxxxxxxx> >> > Signed-off-by: Howard Hsu <howard-yh.hsu@xxxxxxxxxxxx> >> > Co-developed-by: MeiChia Chiu <meichia.chiu@xxxxxxxxxxxx> >> > Signed-off-by: MeiChia Chiu <meichia.chiu@xxxxxxxxxxxx> >> > Co-developed-by: StanleyYP Wang <StanleyYP.Wang@xxxxxxxxxxxx> >> > Signed-off-by: StanleyYP Wang <StanleyYP.Wang@xxxxxxxxxxxx> >> > Co-developed-by: Money Wang <Money.Wang@xxxxxxxxxxxx> >> > Signed-off-by: Money Wang <Money.Wang@xxxxxxxxxxxx> >> > Co-developed-by: Evelyn Tsai <evelyn.tsai@xxxxxxxxxxxx> >> > Signed-off-by: Evelyn Tsai <evelyn.tsai@xxxxxxxxxxxx> >> > Signed-off-by: Shayne Chen <shayne.chen@xxxxxxxxxxxx> >> > --- >> > drivers/net/wireless/mediatek/mt76/Kconfig | 1 + >> > drivers/net/wireless/mediatek/mt76/Makefile | 1 + >> > .../net/wireless/mediatek/mt76/mt7996/Kconfig | 12 + >> > .../wireless/mediatek/mt76/mt7996/Makefile | 6 + >> > .../wireless/mediatek/mt76/mt7996/debugfs.c | 851 ++++ >> > .../net/wireless/mediatek/mt76/mt7996/dma.c | 360 ++ >> > .../wireless/mediatek/mt76/mt7996/eeprom.c | 229 ++ >> > .../wireless/mediatek/mt76/mt7996/eeprom.h | 75 + >> > .../net/wireless/mediatek/mt76/mt7996/init.c | 816 ++++ >> > .../net/wireless/mediatek/mt76/mt7996/mac.c | 2468 ++++++++++++ >> > .../net/wireless/mediatek/mt76/mt7996/mac.h | 398 ++ >> > .../net/wireless/mediatek/mt76/mt7996/main.c | 1325 +++++++ >> > .../net/wireless/mediatek/mt76/mt7996/mcu.c | 3428 >> > +++++++++++++++++ >> > .../net/wireless/mediatek/mt76/mt7996/mcu.h | 662 ++++ >> > .../net/wireless/mediatek/mt76/mt7996/mmio.c | 385 ++ >> > .../wireless/mediatek/mt76/mt7996/mt7996.h | 516 +++ >> > .../net/wireless/mediatek/mt76/mt7996/pci.c | 222 ++ >> > .../net/wireless/mediatek/mt76/mt7996/regs.h | 533 +++ >> > 18 files changed, 12288 insertions(+) >> >> This patch is too big, please split it. One patch per file is a good >> rule of thumb. >> > > Hi Kalle, > > Thanks for comments. > > It's a bit hard to adjugement to us actually. We'd prefer to keeping > one topic (wifi7 thing support for this case) one patch. I guess add > code that is nor used or does not compile could get other complaints. Applying it to the git tree as one big commit is fine, but for reviews I always recommend splitting new drivers to one file per patch. I tried to review this huge patch and gave up, it was just too difficult. > Given that the series has been merged to Felix's tree (and couple > patches are being applied on top of his tree)... but we will take care > of this part next time and split the series by functionality as much as > we can. What do you think? One option is to send followup patches to handle the issues found during review. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
