On Tue, Nov 22, 2022 at 03:52:15PM +0100, Sascha Hauer wrote: > This is the third round of adding support for the USB variants to the > RTW88 driver. There are a few changes to the last version which make it > worth looking at this version. > > First of all RTL8723du and RTL8821cu are tested working now. The issue > here was that the txdesc checksum calculation was wrong. I found the > correct calculation in various downstream drivers found on github. > > The second big issue was that TX packet aggregation was wrong. When > aggregating packets each packet start has to be aligned to eight bytes. > The necessary alignment was added to the total URB length before > checking if there is another packet to aggregate, so the URB length > included that padding after the last packet, which is wrong. Fixing > this makes the driver work much more reliably. > > I added all people to Cc: who showed interest in this driver and I want > to welcome you for testing and reviewing. There still is a problem with the RTL8822cu chipset I have here. When using NetworkManager I immediately lose the connection to the AP after it has been connected: [ 376.213846] wlan0: authenticate with 76:83:c2:ce:81:b1 [ 380.085463] wlan0: send auth to 76:83:c2:ce:81:b1 (try 1/3) [ 380.091446] wlan0: authenticated [ 380.108864] wlan0: associate with 76:83:c2:ce:81:b1 (try 1/3) [ 380.136448] wlan0: RX AssocResp from 76:83:c2:ce:81:b1 (capab=0x1411 status=0 aid=2) [ 380.202955] wlan0: associated [ 380.268140] IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready [ 380.275328] wlan0: Connection to AP 76:83:c2:ce:81:b1 lost That doesn't happen when using plain wpa_supplicant. This seems to go down to cd96e22bc1da ("rtw88: add beacon filter support"). After being connected I get a BCN_FILTER_CONNECTION_LOSS beacon. Plain wpa_supplicant seems to go another code patch and doesn't activate connection quality monitoring. The connection to the AP works fluently also with NetworkManager though when I just ignore the BCN_FILTER_CONNECTION_LOSS beacon. Any idea what may be wrong here? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |