On 11/18/22 22:06, Kees Cook wrote:
Remove struct pda_antenna_gain. It was unused and was using
deprecated 0-length arrays[1].
I would like to keep it around. This struct is documenting what's coded
in the PDR_ANTENNA_GAIN eeprom (specifically that units value
(0.25 dBi units)).
[1] https://github.com/KSPP/linux/issues/78
Cc: Christian Lamparter <chunkeey@xxxxxxxxxxxxxx>
Cc: Kalle Valo <kvalo@xxxxxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
Cc: Paolo Abeni <pabeni@xxxxxxxxxx>
Cc: "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx>
Cc: linux-wireless@xxxxxxxxxxxxxxx
Cc: netdev@xxxxxxxxxxxxxxx
Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
---
drivers/net/wireless/intersil/p54/eeprom.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/wireless/intersil/p54/eeprom.h b/drivers/net/wireless/intersil/p54/eeprom.h
index 1d0aaf54389a..10b6d96aa49e 100644
--- a/drivers/net/wireless/intersil/p54/eeprom.h
+++ b/drivers/net/wireless/intersil/p54/eeprom.h
@@ -107,13 +107,6 @@ struct pda_country {
u8 flags;
} __packed;
-struct pda_antenna_gain {
- struct {
- u8 gain_5GHz; /* 0.25 dBi units */
- u8 gain_2GHz; /* 0.25 dBi units */
- } __packed antenna[0];
-} __packed;
-
struct pda_custom_wrapper {
__le16 entries;
__le16 entry_size;
