Ryder Lee <ryder.lee@xxxxxxxxxxxx> writes: > Host triggered and catastrophic event triggered firmware core dumping > for basic firmware issues triage, including state reporting, task/irq > info, function calltrace and MCU memory dump. If you add module parameters please always document them in the commit log. > +static bool coredump_memdump; > +module_param(coredump_memdump, bool, 0644); Please also add documentation here so that it's visible with modinfo command. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches