Hi johannes, First of all, thank you very much for the review and feedback. This mail is corrected part of your feedback. "freq_offset" also needs to be compared on S1G Band. If freq_offset comparison is omitted in cmp_bss, other bss cannot be distinguished in units of khz. Signed-off-by: JUN-KYU SHIN <jk.shin@xxxxxxxxxxxx> --- net/wireless/scan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/wireless/scan.c b/net/wireless/scan.c index 3cfc668c4189..22ae8996ada3 100644 --- a/net/wireless/scan.c +++ b/net/wireless/scan.c @@ -1289,8 +1289,8 @@ static int cmp_bss(struct cfg80211_bss *a, int i, r; if (a->channel != b->channel) - return ((b->channel->center_freq + b->channel->freq_offset) - - (a->channel->center_freq + a->channel->freq_offset)); + return ((b->channel->center_freq + (u32)b->channel->freq_offset) - + (a->channel->center_freq + (u32)a->channel->freq_offset)); a_ies = rcu_access_pointer(a->ies); if (!a_ies) -- 2.25.1