Kalle Valo <kvalo@xxxxxxxxxx> writes: >>> +int ath12k_dbring_buf_setup(struct ath12k *ar, >>> + struct ath12k_dbring *ring, >>> + struct ath12k_dbring_cap *db_cap) >>> +{ >>> + struct ath12k_base *ab = ar->ab; >>> + struct hal_srng *srng; >>> + int ret; >>> + >>> + srng = &ab->hal.srng_list[ring->refill_srng.ring_id]; >>> + ring->bufs_max = ring->refill_srng.size / >>> + ath12k_hal_srng_get_entrysize(ab, HAL_RXDMA_DIR_BUF); >>> + >>> + ring->buf_sz = db_cap->min_buf_sz; >>> + ring->buf_align = db_cap->min_buf_align; >>> + ring->pdev_id = db_cap->pdev_id; >>> + ring->hp_addr = ath12k_hal_srng_get_hp_addr(ar->ab, srng); >>> + ring->tp_addr = ath12k_hal_srng_get_tp_addr(ar->ab, srng); >> >> s/ar->ab/ab/ in both of the above since you already have ab = ar->ab > > This is still not fixed. This is now fixed. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches