(removing Amitkumar Karwar <amit.karwar@xxxxxxxxxxxxxxxxxx> as that keeps bouncing) On Fri, 2022-11-04 at 17:23 +0100, Johannes Berg wrote: > On Fri, 2022-11-04 at 17:09 +0100, Marek Vasut wrote: > > > > In V2 it was suggested I deduplicate this into a separate function, > > since the test is done in multiple places. I would like to keep it > > deduplicated. > > Well, it's now a lot simpler, so one might argue that it's not needed. > > But anyway you're touching the hot-path of this driver, and making it an > inline still keeps it de-duplicated, so not sure why you wouldn't just > move the rsi_is_tx_eapol into the header file as static inline? > Though honestly, if we thought it was worth deduplicating a simple bit check like that, we could define an inline helper in mac80211.h. I'm not really convinced it is :) But hey, that's not my driver, so ultimately I don't _really_ care so much. johannes
