Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > The <linux/bcma/bcma_driver_chipcommon.h> is including the legacy > header <linux/gpio.h> to obtain struct gpio_chip. Instead, include > <linux/gpio/driver.h> where this struct is defined. > > It turns out that the brcm80211 brcmsmac depends on this to > bring in the symbol gpio_is_valid(). > > The driver looks up the BCMA parent GPIO driver and checks that > this succeeds, but then it goes on to use the deprecated GPIO > call gpio_is_valid() to check the consistency of the .base > member of the BCMA GPIO struct. The whole check can be dropped > because the bcma_gpio is initialized in the declarations: > > struct gpio_chip *bcma_gpio = &cc_drv->gpio; > > And this can never be NULL. > > Cc: Jonas Gorski <jonas.gorski@xxxxxxxxx> > Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Patch applied to wireless-next.git, thanks. 2b6c0e152868 bcma: Use the proper gpio include -- https://patchwork.kernel.org/project/linux-wireless/patch/20221028092332.238728-1-linus.walleij@xxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
