Youghandhar Chintala <quic_youghand@xxxxxxxxxxx> wrote: > Currently after the hardware restart triggered from the driver, the > station interface connection remains intact, since a disconnect trigger > is not sent to userspace. This can lead to a problem in targets where > the wifi mac sequence is added by the firmware. > > After the target restart, its wifi mac sequence number gets reset to > zero. Hence AP to which our device is connected will receive frames with > a wifi mac sequence number jump to the past, thereby resulting in the > AP dropping all these frames, until the frame arrives with a wifi mac > sequence number which AP was expecting. > > To avoid such frame drops, its better to trigger a station disconnect > upon target hardware restart which can be done with API > ieee80211_reconfig_disconnect exposed to mac80211. > > The other targets are not affected by this change, since the hardware > params flag is not set. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1 > > Signed-off-by: Youghandhar Chintala <quic_youghand@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> This had a new warning: drivers/net/wireless/ath/ath11k/mac.c:8056: Blank lines aren't necessary before a close brace '}' I fixed it in the pending branch. -- https://patchwork.kernel.org/project/linux-wireless/patch/20221104085403.11025-1-quic_youghand@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
