Search Linux Wireless

Re: [PATCH v3 5/5] wifi: rtl8xxxu: Use dev_info instead of pr_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/11/2022 13:11, Kalle Valo wrote:
> Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> writes:
> 
>> Replace two instances of bare pr_info with dev_info.
>>
>> Also make their messages a little more informative.
>>
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>
> 
> [...]
> 
>> @@ -5420,7 +5421,8 @@ static void rtl8xxxu_rx_urb_work(struct work_struct *work)
>>  			rtl8xxxu_queue_rx_urb(priv, rx_urb);
>>  			break;
>>  		default:
>> -			pr_info("failed to requeue urb %i\n", ret);
>> +			dev_info(&priv->udev->dev,
>> +				 "failed to requeue urb with error %i\n", ret);
> 
> Should this be dev_warn()? It looks like a warning.
> 
Probably yes. I'll do that and also rebase everything.



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux