On 11/1/2022 2:31 PM, Kalle Valo wrote:
(fixing quotation)
"Youghandhar Chintala (Temp)" <quic_youghand@xxxxxxxxxxx> writes:
On 10/28/2022 12:19 AM, Jeff Johnson wrote:
On 10/26/2022 3:22 AM, Youghandhar Chintala wrote:
+static void ath10k_qmi_add_wlan_ver_smem(struct ath10k *ar, char
*fw_build_id)
const char *fw_build_id?
+{
+ u8 *smem_table_ptr;
+ size_t smem_block_size;
+ const u32 version_string_size = 128;
should you s/128/MAX_BUILD_ID_LEN/ since that is what is used to
size qmi->fw_build_id?
or alternately have the caller pass fw_build_id length as a separate
param?
Sure Jeff. Will address it in next version of patch.
BTW Youghandhar, your quotes were broken in this mail so your reply was
difficult to find. See here:
https://patchwork.kernel.org/project/linux-wireless/patch/20221026102257.19919-1-quic_youghand@xxxxxxxxxxx/
If you are using Outlook, I recommend switching to an application which
respects standards more :) For example, some people seem to be happy
with Thunderbird.
Thank you so much for your suggestion. I will address it.
Currently I am using Thunderbird.
