On 2022/10/23 16:16, Leon Romanovsky wrote:
On Fri, Oct 21, 2022 at 09:57:38PM +0800, Yang Yingliang wrote:
Replace BUG_ON() with WARN_ON() to handle fault more gracefully.
Suggested-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
---
net/rfkill/core.c | 25 ++++++++++++++++---------
1 file changed, 16 insertions(+), 9 deletions(-)
Please add changelog and version numbers when you set your series.
The same comment as https://lore.kernel.org/all/Y1T3a1y/pWdbt2ow@unreal
The link is unreachable.
or you should delete BUG_ONs completely or simply replace them with WARN_ONs.
There is no need in all these if (...).
If remove BUG_ONs or not use if (...), it may lead null-ptr-deref, it's
same as
using BUG_ON(), which leads system crash.
Thanks,
Yang
Thanks
.
