On Mon, Oct 27, 2008 at 05:15:53PM -0400, John W. Linville wrote: > On Mon, Oct 27, 2008 at 11:56:34AM -0700, Greg KH wrote: > > On Fri, Oct 24, 2008 at 03:48:59PM -0400, John W. Linville wrote: > > > This updates drivers/staging/at76_usb to correspond with the latest > > > version previously available in wireless-testing. > > > > > > Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx> > > > > I've applied this, but it does add the following warnings, which I don't > > think you want to have: > > drivers/staging/at76_usb/at76_usb.c:885: warning: ‘at76_set_associd’ defined but not used > > drivers/staging/at76_usb/at76_usb.c:903: warning: ‘at76_set_listen_interval’ defined but not used > > drivers/staging/at76_usb/at76_usb.c:989: warning: ‘at76_add_mac_address’ defined but not used > > > > > > I'll remove these unused functions now from the in-kernel version. > > Those were still there because Kalle had said he intended to use them. > I see no need to carry them since you have them in git anyway. Heh, fine, they are now gone, we can't add patches that add warnings :) > > Is there any way to do development on this in the staging version now, > > instead of the wireless-testing tree? > > Fine with me, although I do have at least one patch for it that > relates to a pending API change -- I just figured I'd wait for the > round-trip of the patch above and then carry just that patch in my > tree along with the mac80211 API changes that prompted it. Any other > development makes sense to go to your tree. How about just sending that patch in when the api change goes in. I have no problem with other people sending in patches through their trees that touch the staging directory for stuff like this, as it makes your life much easier. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
