On Mon, Oct 17, 2022 at 03:36:20PM -0500, Gustavo A. R. Silva wrote:
> [...]
> @@ -6312,16 +6326,16 @@ static int airo_get_mode(struct net_device *dev,
> /* If not managed, assume it's ad-hoc */
> switch (local->config.opmode & MODE_CFG_MASK) {
> case MODE_STA_ESS:
> - *uwrq = IW_MODE_INFRA;
> + uwrq->mode = IW_MODE_INFRA;
> break;
> case MODE_AP:
> - *uwrq = IW_MODE_MASTER;
> + uwrq->mode = IW_MODE_MASTER;
> break;
> case MODE_AP_RPTR:
> - *uwrq = IW_MODE_REPEAT;
> + uwrq->mode = IW_MODE_REPEAT;
> break;
> default:
> - *uwrq = IW_MODE_ADHOC;
> + uwrq->mode = IW_MODE_ADHOC;
> }
>
> return 0;
Sometimes you use the union directly, sometimes not. What was your
heuristic for that?
Regardless, looks good!
Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
--
Kees Cook
