Muna Sinada <quic_msinada@xxxxxxxxxxx> wrote:
> HE PHY is only 11 bytes, therefore it should be using byte indexes
> instead of dword. Change corresponding macros to reflect this.
>
> Signed-off-by: Muna Sinada <quic_msinada@xxxxxxxxxxx>
Fails to build. How did you test this if it doesn't even build? ALL
patches submitted to upstream need to be properly tested before
submission.
drivers/net/wireless/ath/ath11k/mac.c: In function 'ath11k_mac_set_he_txbf_conf':
drivers/net/wireless/ath/ath11k/mac.c:2711:33: error: 'struct ieee80211_bss_conf' has no member named 'he_su_beamformer'
2711 | if (arvif->vif->bss_conf.he_su_beamformer) {
| ^
drivers/net/wireless/ath/ath11k/mac.c:2713:41: error: 'struct ieee80211_bss_conf' has no member named 'he_mu_beamformer'
2713 | if (arvif->vif->bss_conf.he_mu_beamformer &&
| ^
drivers/net/wireless/ath/ath11k/mac.c:2722:41: error: 'struct ieee80211_bss_conf' has no member named 'he_full_ul_mumimo'
2722 | if (arvif->vif->bss_conf.he_full_ul_mumimo)
| ^
drivers/net/wireless/ath/ath11k/mac.c:2725:41: error: 'struct ieee80211_bss_conf' has no member named 'he_su_beamformee'
2725 | if (arvif->vif->bss_conf.he_su_beamformee)
| ^
make[5]: *** [scripts/Makefile.build:249: drivers/net/wireless/ath/ath11k/mac.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [scripts/Makefile.build:465: drivers/net/wireless/ath/ath11k] Error 2
make[3]: *** [scripts/Makefile.build:465: drivers/net/wireless/ath] Error 2
make[2]: *** [scripts/Makefile.build:465: drivers/net/wireless] Error 2
make[1]: *** [scripts/Makefile.build:465: drivers/net] Error 2
make: *** [Makefile:1853: drivers] Error 2
4 patches set to Changes Requested.
13005351 [1/4] wifi: ath11k: modify accessor macros to match index size
13005352 [2/4] wifi: ath11k: push MU-MIMO params from hostapd to hardware
13005353 [3/4] wifi: ath11k: move HE MCS mapper to a separate function
13005354 [4/4] wifi: ath11k: generate rx and tx mcs maps for supported HE mcs
--
https://patchwork.kernel.org/project/linux-wireless/patch/1665599807-12908-2-git-send-email-quic_msinada@xxxxxxxxxxx/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
