Karthikeyan Kathirvel <quic_kathirve@xxxxxxxxxxx> writes: > This patchset adds support for IPQ5018. > - IPQ5018 is a AHB based 2G 2x2 device. > - The CE reg space in IPQ5018 is not part of WCSS as in IPQ8074 > or IPQ6018 and these sections (CE register space and WCSS) are not > contiguous, hence the ce space is io remapped separately and > the registers are handle accordingly based on the offset. > - The rx descriptors are similar to QCN9074 > - The hw ops are similar to QCN9074 except for rx hash computation which > is defined newly > - The UMAC registers are different, hence new MACROS are defined for > their usage. > > Tested-on : IPQ5018 hw1.0 AHB WLAN.HK.2.5.0.1-01192-QCAHKSWPL_SILICONZ-1 v1 This should be: Tested-on: IPQ5018 hw1.0 AHB WLAN.HK.2.5.0.1-01192-QCAHKSWPL_SILICONZ-1 v1 The format is documented here: https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches#tested-on_tag Also you seem to be using an old firmware, please update to the version we are using in upstream: https://github.com/kvalo/ath11k-firmware/tree/master/IPQ5018/hw1.0/2.6.0.1/WLAN.HK.2.6.0.1-00861-QCAHKSWPL_SILICONZ-1 And remember to use ath11k-check, this patchset has a lot of new warnings: drivers/net/wireless/ath/ath11k/core.h:1151: Please don't use multiple blank lines drivers/net/wireless/ath/ath11k/ahb.c:287: Alignment should match open parenthesis drivers/net/wireless/ath/ath11k/hw.c:2159: line length of 103 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2164: line length of 102 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2169: line length of 103 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2174: line length of 102 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2179: line length of 103 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2184: line length of 102 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2189: line length of 103 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2194: line length of 102 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2199: line length of 103 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2204: line length of 102 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2210: line length of 103 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2215: line length of 102 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2221: line length of 103 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2226: line length of 102 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2231: line length of 103 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2236: line length of 102 exceeds 90 columns drivers/net/wireless/ath/ath11k/hw.c:2241: line length of 102 exceeds 90 columns And most importantly this patchset breaks my tests with WCN6855: [ 366.915173] ath11k_pci 0000:06:00.0: chip_id 0x2 chip_family 0xb board_id 0x106 soc_id 0x400c0200 [ 366.915425] ath11k_pci 0000:06:00.0: fw_version 0x11090c35 fw_build_timestamp 2022-04-18 20:23 fw_build_id WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.9 [ 367.030091] ath11k_pci 0000:06:00.0: ignore reset dev flags 0xc800 [ 368.111239] ath11k_pci 0000:06:00.0: failed to receive control response completion, polling.. [ 368.352229] Run module-load (3/3) [ 369.135172] ath11k_pci 0000:06:00.0: ctl_resp never came in (-110) [ 369.135269] ath11k_pci 0000:06:00.0: failed to connect to HTC: -110 [ 369.171910] ath11k_pci 0000:06:00.0: failed to start core: -110 [ 369.180182] failed to send QMI message [ 369.180373] ath11k_pci 0000:06:00.0: failed to send wlan mode request (mode 4): -5 [ 369.180432] ath11k_pci 0000:06:00.0: qmi failed to send wlan mode off: -5 -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
