Search Linux Wireless

Re: [PATCH v2 2/3] wifi: mac80211: add wake_tx_queue callback to drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2022-10-10 at 18:16 +0200, Martin Blumenstingl wrote:
> [...]
> > diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c
> > index 07578ccc4bab..bf917ef20e3b 100644
> > --- a/drivers/net/wireless/realtek/rtw88/mac80211.c
> > +++ b/drivers/net/wireless/realtek/rtw88/mac80211.c
> > @@ -896,6 +896,7 @@ static void rtw_ops_sta_rc_update(struct ieee80211_hw *hw,
> >  
> >  const struct ieee80211_ops rtw_ops = {
> >  	.tx			= rtw_ops_tx,
> > +	.wake_tx_queue		= ieee80211_handle_wake_tx_queue,
> >  	.wake_tx_queue		= rtw_ops_wake_tx_queue,
> >  	.start			= rtw_ops_start,
> >  	.stop			= rtw_ops_stop,
> > diff --git a/drivers/net/wireless/realtek/rtw89/mac80211.c b/drivers/net/wireless/realtek/rtw89/mac80211.c
> > index a296bfa8188f..91674c63b9f9 100644
> > --- a/drivers/net/wireless/realtek/rtw89/mac80211.c
> > +++ b/drivers/net/wireless/realtek/rtw89/mac80211.c
> > @@ -918,6 +918,7 @@ static int rtw89_ops_set_tid_config(struct ieee80211_hw *hw,
> >  
> >  const struct ieee80211_ops rtw89_ops = {
> >  	.tx			= rtw89_ops_tx,
> > +	.wake_tx_queue		= ieee80211_handle_wake_tx_queue,
> >  	.wake_tx_queue		= rtw89_ops_wake_tx_queue,
> >  	.start			= rtw89_ops_start,
> >  	.stop			= rtw89_ops_stop,
> 
> For rtw88 and rtw89 the wake_tx_queue callback is now duplicated.
> I'm not sure if other drivers are affected as well.
> 

Ouch. I looked at a whole bunch of them, how did that not cause a
compiler warning??

I'll check and fix.

johannes




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux