Ian Lin <ian.lin@xxxxxxxxxxxx> writes:
> From: Wright Feng <wright.feng@xxxxxxxxxxx>
>
> Currently, host only reads console buffer when receiving mailbox data or
> hit crash with PCIE bus. Therefore, we add timer in PCIE code to read
> console buffer periodically to help developer and user check firmware
> message when there is no data transmission between host and dongle.
>
> Signed-off-by: Wright Feng <wright.feng@xxxxxxxxxxx>
> Signed-off-by: Chi-hsien Lin <chi-hsien.lin@xxxxxxxxxxx>
> Signed-off-by: Ian Lin <ian.lin@xxxxxxxxxxxx>
[...]
> @@ -340,6 +342,11 @@ struct brcmf_pciedev_info {
> u16 value);
> struct brcmf_mp_device *settings;
> struct brcmf_otp_params otp;
> +#ifdef DEBUG
> + u32 console_interval;
> + bool console_active;
> + struct timer_list timer;
> +#endif
> };
I was wondering where that DEBUG is defined and found that it's done in
the Makefile:
subdir-ccflags-$(CONFIG_BRCMDBG) += -DDEBUG
I think that DEBUG define should be removed and instead CONFIG_BRCMDBG
should be used all over the brcmfmac and brcmsmac code. A cleanup patch
doing this is very welcome.
This would be a good task for someone new to kernel development, is
there a way to report these kind of simple tasks?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
