On 10/2/22 10:59, Jakub Kicinski wrote:
On Sun, 2 Oct 2022 10:24:27 -0700 Guenter Roeck wrote:
On Tue, Sep 27, 2022 at 06:27:53AM -0700, Jakub Kicinski wrote:
We tell driver developers to always pass NAPI_POLL_WEIGHT
as the weight to netif_napi_add(). This may be confusing
to newcomers, drop the weight argument, those who really
need to tweak the weight can use netif_napi_add_weight().
Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
That seems to have missed some (or at least one) file(s).
Building mips:cavium_octeon_defconfig ... failed
--------------
Error log:
drivers/net/ethernet/cavium/octeon/octeon_mgmt.c: In function 'octeon_mgmt_probe':
drivers/net/ethernet/cavium/octeon/octeon_mgmt.c:1399:9: error: too many arguments to function 'netif_napi_add'
1399 | netif_napi_add(netdev, &p->napi, octeon_mgmt_napi_poll,
| ^~~~~~~~~~~~~~
In file included from include/linux/etherdevice.h:21,
from drivers/net/ethernet/cavium/octeon/octeon_mgmt.c:11:
include/linux/netdevice.h:2562:1: note: declared here
2562 | netif_napi_add(struct net_device *dev, struct napi_struct *napi,
Fix sent, sorry. I don't see any more problems grepping again now..
I think that was the only one. The following coccinelle script helps.
Guenter
---
virtual report
@s@
expression a, b, c, d;
position p;
@@
netif_napi_add@p(a, b, c, d);
@script:python depends on report@
p << s.p;
@@
print "Bad netif_napi_add() call at %s:%s" % (p[0].file, p[0].line)
