Search Linux Wireless

Re: [PATCH] ath5k: Fix reset sequence for AR5212 in general and RF5111 in particular

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2008/10/26 Elias Oltmanns <eo@xxxxxxxxxxxxxx>:
>
>                /*
>                 * Write some more initial register settings
>                 */
> -               if (ah->ah_version == AR5K_AR5212) {
> +               if (ah->ah_version == AR5K_AR5212 &&
> +                   ah->ah_radio > AR5K_RF5111) {

even better: ah->ah_phy_revision > AR5K_SREV_PHY_5212

>                        ath5k_hw_reg_write(ah, 0x0002a002, 0x982c);
>
>                        if (channel->hw_value == CHANNEL_G)
> @@ -858,6 +859,7 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum ieee80211_if_types op_mode,
>
>                        data = ath5k_hw_reg_read(ah, 0xa228);
>                        data &= 0xfffe03ff;
> +                       data |= 0x00000800;
>                        ath5k_hw_reg_write(ah, data, 0xa228);
>                        data = 0;
>

Can you please use the macros from ath5k.h to set these parameters ?
(i got the above from decompiling binary HAL that's why i have fixed
masks -no magic values- but now that we know what's going on we must
make the code human-readable)
And also please change 0xa228 with it's name from reg.h :

2557 #define AR5K_PHY_DAG_CCK_CTL                    0xa228
2558 #define AR5K_PHY_DAG_CCK_CTL_EN_RSSI_THR        0x00000200
2559 #define AR5K_PHY_DAG_CCK_CTL_RSSI_THR           0x0001fc00
2560 #define AR5K_PHY_DAG_CCK_CTL_RSSI_THR_S         10

Normaly i'll update reset.c this week so you can always wait for a
more generic fix ;-)

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux