On 28/09/2022 11:39, Kalle Valo wrote: > Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> writes: > >> On 25/09/2022 19:53, Jes Sorensen wrote: >>> On 9/18/22 08:35, Bitterblue Smith wrote: >>>> Inform the firmware when connecting to a network. This makes the >>>> firmware enable the rate control, which makes the upload faster. >>>> >>>> Don't inform the firmware when disconnecting from a network, because >>>> that makes reconnecting impossible for some reason: >>> >>> Have you dug through the vendor driver to see what it does here? >>> >>> Thanks, >>> Jes >>> >> >> I hadn't investigated, but since you asked :) I looked into it today. >> >> The vendor driver doesn't do anything weird. Our report_connect >> function *should* work. >> >> And it turns out it does work! I restored the original form of the >> function to test something and reconnecting worked. I couldn't >> reproduce the problem anymore. Not much has changed in rtl8xxxu since >> the last time I tried this, so it was easy to find the reason: fixing >> the queue selection [0] fixed the reconnecting problem. Before, it was >> sending the auth attempts using queue 0x7 (TXDESC_QUEUE_VO). With the >> queue selection fix it uses queue 0x12 (TXDESC_QUEUE_MGNT). Perhaps >> queue 0x7 is not functional when the firmware knows it's not connected >> to a network? >> >> I guess I have to send a different patch for this now. > > So what should I do with this patchset? Can I take patches 2-4? > Yes, please. They're all independent.
