On Wed, 2022-09-14 at 18:00 +0800, Wen Gong wrote: > On 7/13/2022 5:44 PM, Johannes Berg wrote: > > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > > > This requires a few more changes. > > > > While at it, also add a warning to ieee80211_get_sband() > > to avoid it being used when there are multiple links. > > > > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> > > --- > > net/mac80211/ieee80211_i.h | 2 ++ > > net/mac80211/mlme.c | 12 ++++++------ > > 2 files changed, 8 insertions(+), 6 deletions(-) > > > > diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h > > index 3e360bcaa03b..a0743c78d171 100644 > > --- a/net/mac80211/ieee80211_i.h > > +++ b/net/mac80211/ieee80211_i.h > > @@ -1539,6 +1539,8 @@ ieee80211_get_sband(struct ieee80211_sub_if_data *sdata) > > struct ieee80211_chanctx_conf *chanctx_conf; > > enum nl80211_band band; > > > > + WARN_ON(sdata->vif.valid_links); > > + > > rcu_read_lock(); > > chanctx_conf = rcu_dereference(sdata->vif.bss_conf.chanctx_conf); > > > Hi Johannes, > > Now I hit below warning here in ieee80211_get_sband() in my MLO test for > station. > Will you have more patch to fix the warning? > Yeah still working on all this, obviously ... That should be fairly harmless for now, unless you're trying to use 1k block-ack. johannes
