On 2022/9/26 15:58, Kalle Valo wrote: > Ruan Jinjie <ruanjinjie@xxxxxxxxxx> writes: > >> On 2022/9/24 0:50, Franky Lin wrote: >>> On Fri, Sep 23, 2022 at 2:42 AM ruanjinjie <ruanjinjie@xxxxxxxxxx> wrote: >>>> >>>> Add missing pci_disable_device() if brcmf_pcie_get_resource() fails. >>> >>> Did you encounter any issue because of the absensent >>> pci_disable_device? A bit more context will be very helpful. >>> >> >> We use static analysis via coccinelle to find the above issue. The >> command we use is below: >> >> spatch -I include -timeout 60 -very_quiet -sp_file >> pci_disable_device_missing.cocci >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c > > Please include this information to the commit log, it helps to > understand the background of the fix. Thank you for your suggestion! I'll include this information in the future commit log. >
