On Sat, Sep 17, 2022 at 12:03:57AM +0100, Daniel Golle wrote: > Over the years we have been accumulating a number of patches improving > support for the IEEE 802.11bgn 2T2R wireless interface built into the > MediaTek MT7620 MIPS SoCs. Many of them have not been in shape for > being submitted to Linux and changes were needed to make checkpatch.pl > all happy. Now they look as good as it gets, given that most code deals > with undocumented registers and was adapted from the vendor driver. > > Patch 1/1 also has been previously submitted and then (imho wrongly) >rejected, so I've included it in this series. In general this looks good. Some calibration functions are just too big, but we can eventually take them and refactor in the tree. Just please assure there are no compilation warnings and add yours signed-off by to all patches. > Alltogether rt2x00 now performs almost as good as the vendor driver, > see benchmark of HT20 client below: > > Accepted connection from 192.168.5.133, port 37382 > [ 5] local 192.168.5.175 port 5201 connected to 192.168.5.133 port 37384 > [ ID] Interval Transfer Bitrate > [ 5] 0.00-1.00 sec 9.57 MBytes 80.3 Mbits/sec > [ 5] 1.00-2.00 sec 9.68 MBytes 81.2 Mbits/sec > [ 5] 2.00-3.00 sec 9.98 MBytes 83.7 Mbits/sec > [ 5] 3.00-4.00 sec 9.72 MBytes 81.6 Mbits/sec > [ 5] 4.00-5.00 sec 9.49 MBytes 79.6 Mbits/sec > [ 5] 5.00-6.00 sec 9.88 MBytes 82.9 Mbits/sec > [ 5] 6.00-7.00 sec 9.76 MBytes 81.8 Mbits/sec > [ 5] 7.00-8.00 sec 9.96 MBytes 83.6 Mbits/sec > [ 5] 8.00-9.00 sec 9.76 MBytes 81.9 Mbits/sec > [ 5] 9.00-10.00 sec 9.86 MBytes 82.7 Mbits/sec > [ 5] 10.00-10.03 sec 243 KBytes 78.4 Mbits/sec > - - - - - - - - - - - - - - - - - - - - - - - - - > [ ID] Interval Transfer Bitrate > [ 5] 0.00-10.03 sec 97.9 MBytes 81.9 Mbits/sec receiver My mt7620 AP benchmarking tests quite highly depended on client devices. With clients like iwlwifi and ath it worked ok. I got pretty poor results when connected rt2x00 client devices :-/ Regards Stanislaw