Hi, On 9/15/22 20:56, Stanislaw Gruszka wrote: > On Thu, Sep 08, 2022 at 07:36:18PM +0200, Hans de Goede wrote: >> Even though ieee80211_hw.queues is set to 2, the ralink rt2x00 driver >> is seeing tx skbs submitted to it with the queue-id set to 2 / set to >> IEEE80211_AC_BE on a rt2500 card when associating with an access-point. > > I'm impressed you have still working rt2500 card :-) I recently become the owner of a Turion64 based MSI S270 laptop to test some kernel code I was refactoring on. This has a mini-pci rt2500 card, which indeed still works after this fix. The thing has 2G RAM and even runs a Fedora 37 beta but the CPU is quite slow and gets pretty toasty. >> This causes rt2x00queue_get_tx_queue() to return NULL and the following >> error to be logged: "ieee80211 phy0: rt2x00mac_tx: Error - Attempt to >> send packet over invalid queue 2", after which association with the AP >> fails. >> >> This patch works around this by mapping QID_AC_BE and QID_AC_BK >> to QID_AC_VI when there are only 2 tx_queues. >> >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > Acked-by: Stanislaw Gruszka <stf_xl@xxxxx> Thanks. Regards, Hans
