> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Sent: Thursday, September 15, 2022 10:14 PM
> To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>; Kevin Yang <kevin_yang@xxxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxx>; Kevin Yang <kevin_yang@xxxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx;
> kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH] wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize()
>
> If request_partial_firmware_into_buf() fails then "firmware" is not
> initialized and the release_firmware(firmware) will crash.
>
> Fixes: deebea35d699 ("wifi: rtw89: early recognize FW feature to decide if chanctx")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
Thank you.
> ---
> drivers/net/wireless/realtek/rtw89/fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
> index 8e4d0e18fa71..2be70b907762 100644
> --- a/drivers/net/wireless/realtek/rtw89/fw.c
> +++ b/drivers/net/wireless/realtek/rtw89/fw.c
> @@ -268,7 +268,7 @@ void rtw89_early_fw_feature_recognize(struct device *device,
> device, &buf, sizeof(buf), 0);
> if (ret) {
> dev_err(device, "failed to early request firmware: %d\n", ret);
> - goto out;
> + return;
> }
>
> ver_code = buf.mfw_hdr.sig != RTW89_MFW_SIG ?
> --
> 2.35.1
>
>
> ------Please consider the environment before printing this e-mail.
