Emmanuel Grumbach <egrumbach@xxxxxxxxx> writes: > On Wed, Sep 7, 2022 at 5:02 PM Toke Høiland-Jørgensen <toke@xxxxxxx> wrote: >> >> From: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> >> >> The iwlmei driver breaks iwlwifi when returning from suspend; the bug >> report[0] has been open for four months now, and now fix seems to be >> forthcoming. Since just disabling the iwlmei driver works as a workaround, >> let's mark the config option as broken until it can be fixed properly. >> >> [0] https://bugzilla.kernel.org/show_bug.cgi?id=215937 >> >> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME") >> Signed-off-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> > > I am not very proud of this, to say the least, but unfortunately, > despite Toke's patience and > his willingness to provide logs and all, I couldn't find the time to fix this. > We had tested against NetworkManager wpa_s, but not against iwd. > From the start, we thought distro wouldn't enable this and this is why > we disabled iwlmei by default. I'm always saying that a Kconfig option is not a "free pass" for anything, some people will enable Kconfig options which they don't understand and they must not break existing features. > This driver is meant to be used by specific groups that need this and > they'll know how to enable this driver even if it is marked as BROKEN. This is just a temporary solution to workaround the regression. But we cannot have broken code forever, so I hope this is properly fixed soon so that the workaround can be removed. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
