On Fri, 2008-10-24 at 10:43 +0800, Zhu Yi wrote:
>
> The patch extends the current regulatory framework to support regulatory
> enforcement by device hardware (firmware). If the regulatory check is
> performed by hardware, the driver uses a special flag to indicate the
> regulatory framework, so that the regulatory framework will bypass all
> the regulatory checks for this device and delegate it to the hardware.
The way I'm reading this, it's incorrect because it doesn't allow the
user to override the hardware's idea of the regulatory domain. I think
it's just a wrong description though.
However, there is another major problem with this, if I use a USB device
that has no regulatory information on a laptop that has this virtual
regdomain configured because of a built-in Intel device, my USB device
will wrongly enable all channels.
But inspired by your patch, here's a different idea:
* remove the struct regdomain hint thing
* introduce a "hardware has regulatory check" flag, which means that
- hardware will enforce regulatory compliance to whatever it thinks
the regulatory domain is
- the driver will, of course, still also enforce the information in
wiphy->bands as it does now
* if a wiphy has the "hw regulatory" flag set and the
cfg80211_regdomain is the world regdomain (whether hard-coded or
gotten from CRDA), then (and only then!) don't apply the
cfg80211_regdomain to it
This would have the following consequences:
+ much less code since all the hint stuff goes away
+ still works for users who move around with a hw-regulatory based
laptop if they set the regdomain to something other than world
manually
- secondary hardware cannot benefit of the, now no longer given, hint
which regdomain the laptop is in and will be restricted to world
- some degree of confusion possible when one device can use channel 13
(say iwl-agn hardware configured for Europe) and another cannot (say
a USB device without regulatory information, leading to the world
regdomain being the used one)
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
