Robert Marko <robert.marko@xxxxxxxxxx> writes: > On Thu, Sep 8, 2022 at 8:46 AM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > >> >> Manikanta Pubbisetty <quic_mpubbise@xxxxxxxxxxx> writes: >> >> > On 9/2/2022 7:16 PM, Robert Marko wrote: >> >> On Fri, Sep 2, 2022 at 3:42 PM Manikanta Pubbisetty >> >> <quic_mpubbise@xxxxxxxxxxx> wrote: >> >>> >> >>> On 9/2/2022 6:50 PM, Robert Marko wrote: >> >>>> On Fri, Sep 2, 2022 at 3:18 PM Manikanta Pubbisetty >> >>>> <quic_mpubbise@xxxxxxxxxxx> wrote: >> >>>>> >> >>>>> Regardless of the chip family, even I feel that the tput changes like >> >>>>> these should be tested on all the chipsets. Availability of the hardware >> >>>>> and time are something which are stopping me in testing the changes on >> >>>>> all supported targets. >> >>>>> >> >>>>> As I said, I had made the changes only to WCN6750 initially (using a >> >>>>> hw_param). Can we take that approach for now and enable this for other >> >>>>> targets only if required & upon thorough testing? >> >>>> >> >>>> I can tell you that on IPQ8074 threaded NAPI really improves perfromance. >> >>>> >> >>> >> >>> Great. Do you have any test results on IPQ8074? >> >> >> >> I dont have full test results, but on Poco F2 Pro as the client @80MHz AX >> >> I got ~720Mbps compared to ~550Mbps before. >> >> >> >> I can tell you that in OpenWrt, we have had it enabled for 6+ months >> >> at this point >> >> and its been really good. >> >> >> > >> > That's a significant improvement, great to hear that. We have another >> > strong reason to have this change in upstream driver. >> >> Indeed, thanks Robert. Is the code in openwrt similar as what >> Manikanta's patch does? > > It's actually identical, we are also just calling dev_set_threaded > before napi_enable. Nice, even better :) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
