> -----Original Message-----
> From: Kalle Valo <kvalo@xxxxxxxxxx>
> Sent: Wednesday, September 7, 2022 3:47 PM
> To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 5/5] wifi: rtw89: support TX diversity for 1T2R chipset
>
> Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes:
>
> > Check RSSI strength to decide which path is better, and then set TX path
> > accordingly.
> >
> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
>
> [...]
>
> > +static void rtw89_phy_tx_path_div_sta_iter(void *data, struct ieee80211_sta *sta)
> > +{
> > + struct rtw89_sta *rtwsta = (struct rtw89_sta *)sta->drv_priv;
> > + struct rtw89_dev *rtwdev = rtwsta->rtwdev;
> > + struct rtw89_vif *rtwvif = rtwsta->rtwvif;
> > + struct rtw89_hal *hal = &rtwdev->hal;
> > + bool *done = (bool *)data;
>
> data is a void pointer, you don't need the cast here.
>
I have sent v2 to fix it.
Thanks.
Ping-Ke
