On Tue, 2022-09-06 at 16:48 +1200, Kieran Frewen wrote:
>
> @@ -805,6 +805,7 @@ static const struct nla_policy nl80211_policy[NUM_NL80211_ATTR] = {
> [NL80211_ATTR_MLD_ADDR] = NLA_POLICY_EXACT_LEN(ETH_ALEN),
> [NL80211_ATTR_MLO_SUPPORT] = { .type = NLA_FLAG },
> [NL80211_ATTR_MAX_NUM_AKM_SUITES] = { .type = NLA_REJECT },
> + [NL80211_ATTR_SHORT_BEACON_PERIOD] = { .type = NLA_U16 },
You probably want _some_ kind of range validation here, like "don't set
it to zero" at least?
> + if (info->attrs[NL80211_ATTR_SHORT_BEACON_PERIOD])
> + params->short_beacon_period =
> + nla_get_u32(info->attrs[NL80211_ATTR_SHORT_BEACON_PERIOD]);
>
And maybe it should be < the long beacon period?
Actually the mac80211 code makes it sound like what you really should
have is a "long beacon period" or something, so that every N beacons you
send a long one?
Or are these really completely independent? It feels like probably the
intention would be to have a (short) beacon period, and then every N
beacons you send a long one?
johannes
