Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx> writes:
> On Monday 29 August 2022 18:03:38 CEST Kalle Valo wrote:
>> Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx> writes:
>>
>> > On Friday 19 August 2022 07:23:43 CEST Dan Carpenter wrote:
>> >> This does a "chunk_len - 4" subtraction later when it calls:
>> >>
>> >> ret = wfx_hif_configuration(wdev, buf + 4, chunk_len - 4);
>> >>
>> >> so check for "chunk_len" is less than 4.
>> >
>> > This patch also ensures that buf[4] won't overflow during:
>> >
>> > if (buf[4] != '{' || buf[chunk_len - 1] != '}')
>> > dev_warn(wdev->dev, "PDS:%d: unexpected content\n", chunk_num);
>> >
>> >> Fixes: dcbecb497908 ("staging: wfx: allow new PDS format")
>> >> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>> >
>> > Reviewed-by: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>
>>
>> BTW Jérôme, as you are the driver maintainer you can use Acked-by.
>
> Reviewed-by does not imply Acked-by?
Acked-by has "stronger" meaning and is meant to use by the maintainer of
the code in question. So anyone can use Reviewed-by but only the
maintainer should use Acked-by. My preference is that maintainers use
Acked-by as then I can easily see from my patchwork script that the
patch is ready to be applied.
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
